-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wizard: fixes #1567
Merged
Merged
wizard: fixes #1567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pabloarosado
approved these changes
Sep 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't run it, but the code looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #1563
FileNotFoundError: [Errno 2] No such file or directory: '.../etl/steps/data/meadow/animal_welfare/2023-09-01/playground.ipynb'
master
. However, Pablo reported that this issue persists inadd-chick-culling-laws-data
even after merging with master recently.dag
file should also be mentioned, if it has been modified.streamlit
under the hood.snapshot.metadata.license
was None, even iflicense
was defined in the.dvc
file. It took me a while to realise that the produced.dvc
file hadlicense
indented too many spaces, hence becoming an item of oforigin
. I think they are meant to be separate fields in the snapshot metadata. Once I removed the indent oflicense
(and its items), the issue was fixed. So, I suppose it's a bug, and wizard should not storelicense
insideorigin
(we can discuss if that should be indeed the correct structure).$.meta.license
and$.meta.origin.license
.Additional issues:
wizard.utils.AppState.defaults
default_last
when callingAppState.st_widget()
wizard
toetl-wizard
for consistency.